Skip to content

Conversation

@Astyyyyy
Copy link
Contributor

@Astyyyyy Astyyyyy commented Nov 6, 2025

ok actually works this time, and properly tested it all with no issues that i can notice, seperated the textbox response calls to be inside the gui_type instead as union seemed to be messing it up

@Astyyyyy Astyyyyy changed the title Fix: fixup sliding textbox inputs Fix: fixup sliding textbox inputs not saving value Nov 6, 2025
@zmerp
Copy link
Member

zmerp commented Nov 7, 2025

I've read the code but I don't quite understand what changes functionally in this PR. Maybe you've duplicated the code and matched and take()n self.editing_value instead of using the reference editing_value_mut. Also you did not use .union(), maybe that was the source of the issue?

@Astyyyyy
Copy link
Contributor Author

Astyyyyy commented Nov 7, 2025

the union is part of the issue, but just removing it isn't enough, and i have it duplicated because with the new ui changes its not using the sliders inbuilt textbox anymore, its a seperate one that gets created which would never get focused with old logic.

im not amazing at code so i dont know a good way of combining both into one response call if you can, and for not using the reference editing_value_mut i just dont know how rusts borrow system really works, if you have a better way you want it done just let me know and ill adjust it.

@zmerp
Copy link
Member

zmerp commented Nov 7, 2025

I wonder why the union was not working. Usually only one control receives one event at a time (if they don't overlap). The union shouldn't be the problem. Then at that point the two blocks don't need to be duplicated anymore. So that leaves nothing that I think actually changes in this PR. I should probably experiment myself

@github-actions github-actions bot added the stale label Jan 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants